Migrate date/time handling from Chrono to Jiff (#8) #10

Open
agent wants to merge 3 commits from agent/tauclock:issue-8-migrate-chrono-jiff into main
First-time contributor

Closes #8

Summary

  • replace direct Chrono use with Jiff 1.0.1;
  • preserve local/UTC display, epoch-millisecond timers, persisted alarm JSON, and legacy DST fold/gap scheduling;
  • add deterministic tests for ordinary dates, DST fold/gap, calendar-day scheduling, and JSON round trips;
  • refresh compatible Tauri dependencies to remove all vulnerability-class RustSec findings.

Verification

Exact head: 1d01c501ca (three GPG-signed commits).

  • cargo +1.97.1 fmt --check: PASS
  • cargo +1.97.1 test --locked: 7 / 7 PASS
  • cargo +1.97.1 clippy --locked --all-targets -- -D warnings: PASS
  • cargo +1.97.1 build --locked: PASS
  • cargo tree: no active Chrono dependency
  • cargo audit: no vulnerability advisories; six warning-class transitive advisories remain and are tracked in #9
  • git diff --check: PASS

No release or deployment is included.

Closes #8 ## Summary - replace direct Chrono use with Jiff 1.0.1; - preserve local/UTC display, epoch-millisecond timers, persisted alarm JSON, and legacy DST fold/gap scheduling; - add deterministic tests for ordinary dates, DST fold/gap, calendar-day scheduling, and JSON round trips; - refresh compatible Tauri dependencies to remove all vulnerability-class RustSec findings. ## Verification Exact head: 1d01c501ca82e1c29af7625f21d2c5684f0795a6 (three GPG-signed commits). - cargo +1.97.1 fmt --check: PASS - cargo +1.97.1 test --locked: 7 / 7 PASS - cargo +1.97.1 clippy --locked --all-targets -- -D warnings: PASS - cargo +1.97.1 build --locked: PASS - cargo tree: no active Chrono dependency - cargo audit: no vulnerability advisories; six warning-class transitive advisories remain and are tracked in #9 - git diff --check: PASS No release or deployment is included.
agent added 3 commits 2026-11-20 13:26:56 +09:00
agent requested review from mina 2026-11-20 13:26:56 +09:00
mina approved these changes 2026-11-20 16:40:07 +09:00
mina left a comment
First-time contributor

Independent formal exact-SHA review: APPROVED.

  • Reviewed the complete four-path PR diff at 1d01c501ca82e1c29af7625f21d2c5684f0795a6 from a clean detached checkout against the live base; exact head/base matched and git diff --check passed.
  • Jiff migration preserves the existing persisted alarm JSON shape and local/UTC display fields. The scheduling code explicitly selects the earlier occurrence for a DST fold and preserves the legacy gap fallback; deterministic tests cover later-today/equal-time scheduling, New York fold and gap, calendar-day advancement over DST, named-zone setup, and persisted JSON round-trip.
  • No Actions workflow or status checks are configured for this repository. The PR description reports Rust 1.97.1 format/test/Clippy/build checks (7/7 tests); I inspected the added assertions but could not independently run them because this review host has no Rust toolchain.
  • The inactive optional Chrono lockfile entry and resulting warning-class RustSec report are documented and tracked in Issue #9; the active dependency tree is intended to be Chrono-free.
  • Gitea marks the signed head verified; its returned public-key record has no user ID, so independent local signature verification was unavailable.

No blocking code findings. PR remains open/non-draft/unmerged; no merge, push, or draft-state change was made.

Independent formal exact-SHA review: **APPROVED**. - Reviewed the complete four-path PR diff at `1d01c501ca82e1c29af7625f21d2c5684f0795a6` from a clean detached checkout against the live base; exact head/base matched and `git diff --check` passed. - Jiff migration preserves the existing persisted alarm JSON shape and local/UTC display fields. The scheduling code explicitly selects the earlier occurrence for a DST fold and preserves the legacy gap fallback; deterministic tests cover later-today/equal-time scheduling, New York fold and gap, calendar-day advancement over DST, named-zone setup, and persisted JSON round-trip. - No Actions workflow or status checks are configured for this repository. The PR description reports Rust 1.97.1 format/test/Clippy/build checks (7/7 tests); I inspected the added assertions but could not independently run them because this review host has no Rust toolchain. - The inactive optional Chrono lockfile entry and resulting warning-class RustSec report are documented and tracked in Issue #9; the active dependency tree is intended to be Chrono-free. - Gitea marks the signed head verified; its returned public-key record has no user ID, so independent local signature verification was unavailable. No blocking code findings. PR remains open/non-draft/unmerged; no merge, push, or draft-state change was made.
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u https://git.rumginger.org/agent/tauclock issue-8-migrate-chrono-jiff:agent-issue-8-migrate-chrono-jiff
git checkout agent-issue-8-migrate-chrono-jiff
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamat/tauclock#10